fix: rustfmt and clippy cleanup after sprint 1-4 merges - #301
Merged
Conversation
cargo fmt --all and cargo clippy -D warnings pass clean. fixes: - redundant closure in execute.rs (set_expire_to_duration) - cloned_ref_to_slice_refs in list.rs (lmove) - formatting across batch.rs, watch.rs, connection.rs, and other files that were committed without running fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
all five sprint PRs (#296-#300) were merged without running
cargo fmt --allorcargo clippy -- -D warningsfirst. this fixes everything in one shot.what was fixed
execute.rs:138— redundant closure:|e| set_expire_to_duration(e)→set_expire_to_durationlist.rs:540—cloned_ref_to_slice_refs:&[value.clone()]→std::slice::from_ref(&value)batch.rs,watch.rs,connection.rs,raft_log.rs,aof.rs,command/mod.rs,server.rs,string.rs,zset.rs— all reformatted bycargo fmt --allwhat was tested
cargo fmt --all --check→ cleancargo clippy --workspace -- -D warnings→ cleancargo test --workspace→ 78 unit/integration tests pass--test-threads 1→ all 79 pass (cluster tests have pre-existing port contention flakiness under parallel execution, unrelated to this pr)